Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include contract_abi in stacks transaction #378

Merged
merged 13 commits into from
Sep 18, 2023
Merged

feat: include contract_abi in stacks transaction #378

merged 13 commits into from
Sep 18, 2023

Conversation

MicaiahReid
Copy link
Contributor

@MicaiahReid MicaiahReid commented Aug 10, 2023 •
edited
Loading

Description

Breaking change?

Example

Checklist

  • All tests pass
  • Tests added in this PR (if applicable)

@MicaiahReid MicaiahReid changed the title feat(wip - don't merge): include contract_abi in stacks transaction feat: include contract_abi in stacks transaction Aug 20, 2023
@MicaiahReid MicaiahReid marked this pull request as ready for review August 20, 2023 19:13
@smcclellan smcclellan linked an issue Aug 21, 2023 that may be closed by this pull request
return contract_abi in Stacks transaction metadata #376
Closed
lgalabru
lgalabru reviewed Aug 28, 2023
View reviewed changes
Copy link
Contributor

@lgalabru lgalabru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding these tests @MicaiahReid!
Is there a way we can get avoid pulling clarity-vm into chainhook-types-rs?
I think I'd be fine with duplicating the code.

@MicaiahReid MicaiahReid force-pushed the include-stacks-contract-abi branch 2 times, most recently from ce20774 to 4d077e9 Compare September 3, 2023 16:57
lgalabru
lgalabru approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@lgalabru lgalabru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks @MicaiahReid!

@MicaiahReid MicaiahReid merged commit 5503c3d into develop Sep 18, 2023
1 check passed
@MicaiahReid MicaiahReid deleted the include-stacks-contract-abi branch September 18, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgalabru lgalabru lgalabru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

return contract_abi in Stacks transaction metadata
2 participants
@MicaiahReid @lgalabru